Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.22 #14460 +/- ##
=========================================
Coverage 18.07% 18.07%
- Complexity 16357 16361 +4
=========================================
Files 5937 5937
Lines 537029 537058 +29
Branches 65833 65836 +3
=========================================
+ Hits 97043 97054 +11
- Misses 428901 428919 +18
Partials 11085 11085
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
||
| private void reconcileNicsForRunningVm(final VMInstanceVO vm) { | ||
| final VMInstanceVO runningVm = _vmDao.findById(vm.getId()); | ||
| if (runningVm == null || runningVm.getType() != VirtualMachine.Type.User || runningVm.getState() != State.Running || runningVm.getHostId() == null |
There was a problem hiding this comment.
does the issue impact DomainRouter ?
There was a problem hiding this comment.
It shouldn't because if it's not userVM we return.
There was a problem hiding this comment.
the VR should not impact the network garbage collector.
is it possble that VR nic is also released when it is reported as Stopped unexpectedly ?
There was a problem hiding this comment.
Oh misinterpreted your statement earlier - I thought you meant does the fix impact VRs - my bad 🤦
That said, I dont think VR was VR is impacted by the issue, and even if it did, we never really took into account VRs nic count, so this fix should only be limited to userVMs.
This branch has not been deployed
2 participants
Description
This PR fixes: #14177
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?